FreedomBen / dory

Your development proxy for docker
MIT License
156 stars 24 forks source link

Server names hash bucket size. #16

Closed ThePixelDeveloper closed 6 years ago

ThePixelDeveloper commented 7 years ago

Dory suffers from a problem that the dinghy http proxy has fixed.

# Apply fix for very long server names
server_names_hash_bucket_size 128;

Otherwise if try to set longer hostnames you just get the default nginx template.

Speaking of your forked image, is there any reason to keep it round because the dinghy image does support SSL.

FreedomBen commented 7 years ago

Thanks, I'll get an update in to latest dinghy http proxy. In the mean time you can work around it by using whichever image you want for the proxy, by just settings a :dory -> :nginx_proxy -> :image key in your dory.yml. Example:

---
dory:
  nginx_proxy:
    image: codekitchen/dinghy-http-proxy:2.5.8
    enabled: true
    container_name: dory_dinghy_http_proxy
    https_enabled: true
    ssl_certs_dir: ''  # leave as empty string to use default certs

The reason I've still kept the forked version around is because it will automagically work on both 80 and 443 even if you don't give it certs (it will use default certs).

FreedomBen commented 6 years ago

OK, I rebuilt dory-http-proxy on top of latest dinghy proxy (at this time it is 2.5.9) and pushed. Dory has been updated to point to both latest dinghy or latest dory.*

Please let me know if this doesn't fix your problem, and thanks again for reporting the issue :-)

* This will obviously only apply if you aren't overriding it with the aforementioned config option