search

FreedomBen / gimme-dat-canvas

A stupid-easy Canvas Appliance, dockerized no less
2 stars 2 forks source link

docker-compose extends? #1

Open claydiffrient opened 8 years ago

claydiffrient commented 8 years ago

Any advantage of recommending people include canvas- containers (essentially duplicating the canvas-lms docker-compose file) inside their own docker-compose?

Why not just extend it from within your own docker-compose (https://docs.docker.com/compose/extends/#extending-services) ?

So in theory (read: I haven't tried it), you should be able to recommend doing something like this:

# My own projects docker-compose.yml
canvas:
  extends:
    file: path/to/canvas-lms/docker-compose.yml
    service: web

Thoughts?

FreedomBen commented 8 years ago

That's not a bad idea as long as the person has a clone of canvas (also assuming, since I've never tried extends). Part of the goal of this is to not need the canvas source at all.

Definitely seems like a useful thing to add to the docs tho. Thanks :smile:

FreedomBen commented 8 years ago

Or were you saying that they could just extend the docker-compose file that ships with this? That's not a bad idea either (tho it does require cloning this repo) ¯(ツ)/¯