search

FreedomBen / rtl8188ce-linux-driver

This modified version of the RealTek WiFi driver fixes some issues with RealTek cards on Linux.
GNU General Public License v2.0
491 stars 109 forks source link

implicit declaration of function ‘rtl_hal_pwrseqcmdparsing’ #78

Open unallocatedanonymous opened 9 years ago

unallocatedanonymous commented 9 years ago

Unable to compile on Fedora 21, 3.18 kernel due to the following error: implicit declaration of function ‘rtl_hal_pwrseqcmdparsing’

Found this patch which solved the problem: http://www.spinics.net/lists/linux-wireless/msg134699.html

FreedomBen commented 9 years ago

Thanks!

ghost commented 9 years ago

How do you apply this solution? What do you need to modify?

FreedomBen commented 9 years ago

@Sergui2015 : Open up the file rtl8188ee/hw.c and add this include:

#include "../pwrseqcmd.h"

and you should be golden.

ghost commented 9 years ago

I have this problem on Ubuntu 15.04.

When run install.sh I've got the error:

rtl8188ce-linux-driver-master/rtl8188ce-linux-driver/rtl8188ee/hw.c:860:2: error: implicit declaration of function ‘rtl_hal_pwrseqcmdparsing’ [-Werror=implicit-function-declaration] if ( !rtl_hal_pwrseqcmdparsing( rtlpriv, PWR_CUT_ALL_MSK, ^ cc1: some warnings being treated as errors

But I was unable to fix this by adding the line

include "../pwrseqcmd.h"

to file rtl8188ce-linux-driver/rtl8188ee/hw.c

because right after downloading the zip I already HAVE this entry in this file.

Then after I run install.sh I've got the error listed above and the entry disappeared from file hw.c.

If I add it again, I can't ran install.sh again:

[] Now let's compile the driver from source and copy the files to the right directories make: ** No targets specified and no makefile found. Stop. [*] The build has failed! Please make sure you have all dependencies installed and you are building on the correct branch (kernel version, not linux distro version, is most important for the branch)

Please help

ghost commented 9 years ago

Solved by commenting lines 43-46 in install.sh

meneal commented 8 years ago

The latest comment on this is unfortunately incorrect. Commenting out those lines just ignores the fact that there is an error. The correct fix for the 15.04 branch is to add change the entire preamble of hw.c to the following:

#include "../wifi.h"
#include "../efuse.h"
#include "../base.h"
#include "../regd.h"
#include "../cam.h"
#include "../ps.h"
#include "../pci.h"
#include "../pwrseqcmd.h"
#include "reg.h"
#include "def.h"
#include "phy.h"
#include "dm.h"
#include "fw.h"
#include "led.h"
#include "hw.h"
#include "pwrseq.h"

This is the same as it is in the root branch. Making the change above of adding in #include "../pwrseqcmd.h" is dependent on its position in the #includes as far as I have seen. I stupidly tried to add it at the end under pwrseq.h and that totally failed.

ghost commented 8 years ago

Thank you meneal, your fix is okay, should it be added to the repository?...

meneal commented 8 years ago

Yeah I'd think that someone should do a pull request. More likely than not it should be me. Whenever I get a chance I will try to do so.

On Tue, Jan 12, 2016 at 4:59 AM, ulrith notifications@github.com wrote:

Thank you meneal, your fix is okay, should it be added to the repository?...

— Reply to this email directly or view it on GitHub https://github.com/FreedomBen/rtl8188ce-linux-driver/issues/78#issuecomment-170858741 .

FreedomBen commented 8 years ago

@meneal that would be great. If someone can get a pull request put together, I'll merge it.