Issues and Q/A about join-project forms (fobi)

[XaviP]

Some issues I've found:

• I don't find the way to assign a form slug to the project from an admin user (easy with proj manager)
• Some fobi fields needs styling.
• When the captcha is wrong, in the return form the fobi fields are empty.
• Error sending a new join-project form:

ValueError at /joinaproject/join-to-high-performance-center-for-snail-races/
Cannot assign None: "AgentAssociation.is_associate" does not allow null values.

[bum2]

Thanks @bhaugen , i've merged again your commits and testing in testocp... The url redirect is correct. Sorry, i can't test the emails in local, i'm trying to add the destination users for the notification: both coordinators and the candidate. Not yet receiving emails... I'm on it

[bhaugen]

@bum2 I won't do any more on this today, Lynn and I need to prep for a presentation to a Hull UK mutual aid network meeting tomorrow morning.

[bhaugen]

Sorry, i can't test the emails in local,

@XaviP and I have tinkered with this before. I think we can figure out a way to test them locally without an outgoing email server. If it becomes a priority, I think I can come up with a method.

[XaviP]

Here an explanation by @bhaugen on how to debug emails in local (two messages): https://github.com/FreedomCoop/valuenetwork/issues/128#issuecomment-243579244

[bhaugen]

Thanks, @XaviP - I think we could put some that code in a script that you could run from the shell.

[bhaugen]

@bum2 I think I finally finally figured out how to fix the annoying two-click Save bug in the Create OCP Account form. I committed, but then I pulled your latest changes to master and retested before I pushed my changes to master. And ran into this bug:

Exception Type: AttributeError
Exception Value:    
'NoneType' object has no attribute 'user'
Exception Location: /home/bob/.virtualenvs/fc18x/valuenetwork/work/views.py in create_account_for_join_request, line 2437

The error line is

users.append(manager.user().user)

I'm no longer frustrated by that annoying bug anymore, so I'll wait to push my change until you tell me you are done and I can retest it. No rush, we're doing a presentation this morning.

If you want some help with your bug, let me know and I'll see what I can do when I get time.

[bum2]

I have added yesterday night a if manager: in that for loop, and since then it seems stable for me. I found the same error... Marvelous if you fixed the double save click issue! i go to pull and test this fix in local and testocp.

[bhaugen]

I haven't pushed my fix because I can't retest it. I have your if manager: line in the code that failed for me locally.

for manager in managers:
                            if manager:
                                users.append(manager.user().user)

[edit: since manager is the loop variable, I think if any managers exist, there will always be a manager inside the loop.]

[bhaugen]

I found the problem, and am fixing it. Will push when done.

[bhaugen]

Ok, pushed.

[bum2]

Thanks for the fix @bhaugen ! Is working good in testocp afaik (also the notifications). If someone can test one more time the 3 new user roles (coordinator, candidate-participant and active-participant), then i think is ready to put in prod.

[XaviP]

New release v0.9.4 https://github.com/FreedomCoop/valuenetwork/releases/tag/v0.9.4 Closing this issue. Please, open new issues with more concrete definition about bugs or features in fobi forms.