search

FreedomCoop / valuenetwork

Fork coming from NRP-Sensorica to use and work for FREEDOM COOP
http://fair.coop
GNU Affero General Public License v3.0
31 stars 12 forks source link

Prevent deleting plans #472

Open bhaugen opened 5 years ago

bhaugen commented 5 years ago

Plans can now be deleted, even if related events have been reported. The events do not get deleted, but th plan can be deleted.

I think for now we should remove the buttons that can delete plans from the Demand and Open Orders pages and anywhere else they exist. If somebody created a plan by mistake and nothing has happened on it, a FC Admin could delete it for them. Until we figure out better what the rules should be.

I'm labeling this as a bug.

fosterlynn commented 5 years ago

I think for now we should remove the buttons that can delete plans from the Demand and Open Orders pages and anywhere else they exist. If somebody created a plan by mistake and nothing has happened on it, a FC Admin could delete it for them.

Actually, it is very helpful for people to be able to create plans and delete them easily when they are first creating recipes, to "debug" the recipe. So alternatively, we could tighten up the isDeletable method to only delete the plan/commitments when there are no events reported.

bhaugen commented 5 years ago

@fosterlynn

we could tighten up the isDeletable method to only delete the plan/commitments when there are no events reported.

Ok with me.