search

FreedomCoop / valuenetwork

Fork coming from NRP-Sensorica to use and work for FREEDOM COOP
http://fair.coop
GNU Affero General Public License v3.0
31 stars 12 forks source link

Resource Type forms need more validations #7

Open bhaugen opened 8 years ago

bhaugen commented 8 years ago

FOr example, unit

skoria commented 8 years ago

Name: limit to 128 char: it's currently possible to enter more, although this causes a validation error. Resource Class: remove? Price per unit: maximum price is a bit low at 1m. Maybe 100m? I doubt we'll have work that pays so well but it might be because the prices are in mFAIR or other small units. Photo: restrict photo size or crop/resize (400px?) when uploading. Photo Url and Url field have different validation. It seems the URL field validates a bit more. Still let me put in a very long URL and cause a validation error. This should perhaps be limited from the form itself. Description: limit to something sensible like 1000 chars, or in the list of resource types, perhaps only show a part of this description? Accounting reference: remove? (not sure what it's for!)

It strikes me that the form could have popup help or more assistance as to what these options like accounting reference and resource class are?

bhaugen commented 8 years ago

@skoria - a couple of comments on your suggestions:

Price per unit: maximum price is a bit low at 1m. Maybe 100m? I doubt we'll have work that pays so well but it might be because the prices are in mFAIR or other small units.

Unfortunately, changing the size of quantity fields is a pretty big software change and would require a lot of testing. It's doable, but we might want to be very sure we need it.

It strikes me that the form could have popup help or more assistance as to what these options like accounting reference and resource class are?

The form is already a popup and popups on popups can get really confusing. It's easy to add on-form help text, though.

One advantage to removing Resource Class and Accounting reference is that then we don't need to explain them... :grinning: