search

FreedomIntelligence / TextClassificationBenchmark

A Benchmark of Text Classification in PyTorch
MIT License
600 stars 138 forks source link

Automatically download embeddings #13

Open stefan-it opened 6 years ago

stefan-it commented 6 years ago

Hi,

thanks creating this text classification benchmark!

I wanted to run the basic example python3 main.py --model cnn and I could see that the GloVe embeddings were not downloaded automatically.

The dataHelper.loadData(opt) never calls the Glove constructor, so the embeddings won't be downloaded. But when I change from_torchtext = False to from_torchtext = True the utils.loadData(opt) method calls the Glove constructor.

I guess calling the Glove constructor would be enough to call it before the glove_file declaration (from here)?

wabyking commented 6 years ago

Thanks for your issues. You are right. Would you mind fixing this problem, and I will add you as a collaborators for this project.

stefan-it commented 6 years ago

Cool thanks :) My first attempt for solving this issue is #15.