search

Freegle / iznik-nuxt3

This is the new version of the client code. The iznik-nuxt repository is now historical (for www.ilovefreegle.org) but still used for moderator tools.
https://iznik-nuxt3.vercel.app
GNU General Public License v2.0
7 stars 4 forks source link

Sign in on wider viewports dependent on cookie consent interaction #101

Closed rwd closed 2 months ago

rwd commented 3 months ago

When the viewport is 1,200 pixels wide or more, the sign in button disappears from the header until the cookie consent banner has been interacted with. Either accepting or rejecting restores the visibility of the button.

On narrower viewports, the button remains visible throughout.

This is a bit inconsistent and glitchy anyway, but particularly problematic if one has the (widely used) browser extension I don't care about cookies installed as the banner goes away without interaction but the button does not reappear, leaving no way to sign in.

edwh commented 3 months ago

Thanks. The background is that we have a problem where the (Bootstrap) modals, including the login one, were blocking interaction with the cookie banner. Until I'm smart enough to work out why that is, we're suppressing modals until you've responded to the cookie banner.

I'll have a look with that extension and see if I can find a way to make it work.

edwh commented 2 months ago

Note to self: until we can solve the underlying problem we may need to hackily try to fetch the script to spot that an error has occurred, which we could do after a little while. See for example https://stackoverflow.com/questions/40527328/is-it-possible-to-catch-neterr-blocked-by-client

edwh commented 2 months ago

@rwd Could you give that a whirl now?

rwd commented 2 months ago

@edwh yep, that's done the trick. Thanks!

edwh commented 2 months ago

@rwd Good. Bit of a hack but it'll do the job for the time being.

Thanks for the bug report. I notice you're a Vue/Nuxt dev. Volunteers always welcome...