search

Freemius / wordpress-sdk

https://freemius.com
GNU General Public License v3.0
267 stars 77 forks source link

Plugin Check (PCP) Compatibility #742

Open flowdee opened 1 month ago

flowdee commented 1 month ago

Running tests via the new Plugin Check (PCP) over our plugins throws tons of complaints related to the Freemius WP SDK.

It would be great to get this optimized and sorted out from time to time, before they probably make passing the plugin check a requirement.

Besides that, doesn't hurt to optimize things anyway I guess 😎

vovafeldman commented 1 month ago

Hey @flowdee 👋

Thanks for bringing this up!

I wanted to clarify that the only category relevant for plugin review submission is the "Plugin Repo" category: image

When that category is selected, the Plugin Check (PCP) doesn’t flag any errors related to the Freemius SDK—aside from the updater, which we've already addressed in collaboration with the review team.

We’ve also tested other categories and noticed that PCP relies on stateless static code analysis, which generates tons of false positives. We understand that seeing these alerts can be frustrating, but rest assured, they don’t reflect actual issues with the SDK.

That being said, we’re always keen on improving, and your feedback is appreciated. We’ll continue keeping an eye on this and optimizing where necessary to ensure compliance as we go.

davidkobielski commented 3 weeks ago

@vovafeldman Hi! But with freemius sdk I can't upload a plugin to wordpress org repo. So it makes everything complicated... image

vovafeldman commented 3 weeks ago

Thanks for flagging this, @davidkobielski! We're aware of the issue where the updater class is being flagged as an error, even though we've cleared it with the WordPress.org plugin review team (FYI it's turned off for free products). Interestingly, this only seems to happen when the SDK isn’t included with Composer, so we're actively working on ensuring a smooth experience with Composer-based integrations. We’ll be updating the SDK integration instructions soon to reflect these improvements.