search

FreeosDAO / freeoscontracts

Freeos Smart Contract Code
0 stars 1 forks source link

Question about ticker - seems uninitialised #2

Closed shahidnz closed 3 years ago

shahidnz commented 3 years ago

$FREEOS_TICKER is used without initialising or exporting

it either depends on env of there is a risk that it remains NULL

Please check https://github.com/FreeosDAO/freeoscontracts/blob/master/freeos/freeosticker.sh

tommccann777 commented 3 years ago

The impact of $FREEOS_TICKER not being initialised is that the job would fail. That's ok. It just means we have to keep our eye on whether it is running or not.

Tom

On Sat, Jan 30, 2021 at 12:46 PM M Shahid Siddiqui notifications@github.com wrote:

$FREEOS_TICKER is used without initialising or exporting

it either depends on env of there is a risk that it remains NULL

Please check

https://github.com/FreeosDAO/freeoscontracts/blob/master/freeos/freeosticker.sh

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/FreeosDAO/freeoscontracts/issues/2, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEKES37D742CA77N5RGYN2LS4NCGVANCNFSM4WZWXQDA .

tommccann777 commented 3 years ago

$FREEOS_TICKER is deliberately not set within the shell script.