FreeosDAO / freeoscontracts

Freeos Smart Contract Code
0 stars 1 forks source link

Stake fails for d and v type account : 0 XPR staking is not allowed by the system but is required as per design #6

Closed shahidnz closed 3 years ago

shahidnz commented 3 years ago

For verified type accounts (i.e d and v), the initial staking reqs are 0 XPR.

But stake does not work as it does not allow staking 0.000 XPR See the sheet: https://docs.google.com/spreadsheets/d/1XCA-3SBGl5TGIfOu3NJI9l7x1wb3tmI0ccbqUzX-YEA/edit?ts=6024b267#gid=0

06:31:59 01/03/2021 ~/eosio-wallet$ proton push action eosio.token transfer "[\"${acc}\",\"freeos333333\", \"0.0000 XPR\", \"freeos stake\"]" -p ${acc}@active
Error 3050003: eosio_assert_message assertion failure
Error Details:
assertion failure with message: must transfer positive quantity
pending console output: 
06:37:49 01/03/2021 ~/eosio-wallet$ 

It is a critical bug and needs to be fixed immediately.

shahidnz commented 3 years ago

09:22:00 01/03/2021 ~/eosio-wallet$ proton push action freeos333333 version '[]' -p ${acc}@active executed transaction: 8b1d64a6ba68c5910476b9a372a74b9cb0542b41d0cde3d3666980e24fd04010 96 bytes 146 us

freeos333333 <= freeos333333::version ""

Version = 0.326 XPR warning: transaction executed locally, but may not be confirmed by the network yet ] 09:22:14 01/03/2021 ~/eosio-wallet$ echo $acc eddieeagle 09:22:28 01/03/2021 ~/eosio-wallet$

tommccann777 commented 3 years ago

Accepted as bug. This requires a fix to the claim 'eligibility' function. I will need to discuss with JK as to whether we should expect 'v' users to have to stake after they have been stake-free for several iterations.

shahidnz commented 3 years ago

Hi Tom,

The issue is still present. Checked just:

07:14:11 06/03/2021 ~/eosio-wallet$ proton push action eosio.token transfer "[\"${acc}\", \"freeos333333\",\"0.0000 XPR\", \"freeos stake\"]"  -p $acc@active
Error 3050003: eosio_assert_message assertion failure
Error Details:
assertion failure with message: must transfer positive quantity
pending console output:
07:14:35 06/03/2021 ~/eosio-wallet$

>> Version = 0.329 - it is currently iteration 8
tommccann777 commented 3 years ago

See my answer on the issue affecting badusrbadusr. It is not a feature that users with a 0 XPR stake requirement are considered to be automatically staked as soon as they register.

shahidnz commented 3 years ago

Confirmed. thanks.

On Sat, Mar 6, 2021 at 8:38 PM tommccann777 notifications@github.com wrote:

Closed #6 https://github.com/FreeosDAO/freeoscontracts/issues/6.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/FreeosDAO/freeoscontracts/issues/6#event-4416612510, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMD7OOETJPYZ44P2AA2IWZ3TCHLYHANCNFSM4YMEDBSA .

-- Looking forward to hearing from you.

With best regards, M Shahid Siddiqui Mob 022 612 4096