Add diagonal flip to g2d element

Freescale / gstreamer-imx

GStreamer 1.0 plugins for i.MX platforms

Other

182 stars 127 forks source link

Add diagonal flip to g2d element #281

Closed woutervanh closed 3 years ago

woutervanh commented 3 years ago

imxg2dvideotransform was missing 2 diagonal flips, so I've added them...

dv1 commented 3 years ago

Thanks! I took this as the template for new video direction properties in v2. Closing this since it is implemented there now.

woutervanh commented 3 years ago

I forgot to push my latest change. Above commit is actually wrong. UL_LR and UR_LL are swapped compared to the gstvideo rotations. It was a bit odd if UL_LR meant swapping the corners or taking this axle as flip point... So UL_LR should do a FLIP_V and UR_LL should do a FLIP_H (or take the latest commit on my repo as reference)

dv1 commented 3 years ago

Yeah, I noticed that actually 🙂 I swapped them.