search

Freescale / gstreamer-imx

GStreamer 1.0 plugins for i.MX platforms
Other
184 stars 127 forks source link

imxg2dvideotransform: wrong transformation with crop metadata #303

Closed angelobt closed 1 year ago

angelobt commented 2 years ago

Hi,

running this pipeline

GST_DEBUG=2 gst-launch-1.0 videotestsrc ! 'video/x-raw, width=720, height=576, framerate=25/1, format=UYVY' ! videocrop left=16 right=16 top=48 bottom=48 ! imxg2dvideotransform ! 'video/x-raw, width=688, height=480, framerate=25/1' ! imxg2dvideosink

I get this output

image

Please could you help me understand what I'm missing ?

angelobt commented 2 years ago

I forget to say environment:

cpu: imx6Solo yocto: hardknott kernel: 5.10.35

dv1 commented 2 years ago

I can reproduce this in current OE master. This only happens if videocrop is inserted. I'm looking into it. Keep in mind though that videocrop will copy pixels via the CPU. The imxg2dvideotransform element supports the GstVideoCropMeta. I currently do not know though if that meta can be inserted as an alternative to copying pixels via the videocrop element. Nevermind, this last seems to be wrong - videocrop does not copy pixels. But the alignment is still wrong.

dv1 commented 2 years ago

Sorry, closed by mistake. I added a fix for this issue in 5a3dcaae186a22ce548847c63f6abdeed4909275 . Please check if this also fixes the problem for you.

dv1 commented 1 year ago

Closing this due to inactivity - issue is assumed to have been fixed by the aforementioned commit. If this is not the case, reopen please.