Freescale / meta-freescale

Layer containing NXP hardware support metadata
Other
172 stars 257 forks source link

Add support to NXP's iMX93 SoC A1 revision #1700

Closed jmarcoscosta closed 11 months ago

jmarcoscosta commented 11 months ago

Hello,

I'm currently in a project where the target board is the A1 revision of iMX93, and I picked meta-freescale's BSP to work upon.

At first, I built a core-image-minimal and it didn't boot. As it turns out, the layer only supported building firmware for iMX93's A0 revision. Basically, firmware-sentinel only supports A1 starting at v0.11.

I'm sending this pull request to update firmware-sentinel according to meta-imx's, and I also added some tweaks to dynamically set the firmware name (e.g, mx93a0-ahab-container.img or mx93a1-ahab-container.img), because the current implementation doesn't actually use SECO_FIRMWARE_NAME (and consequently neither IMX_SOC_REV).

Please do not hesitate to point any mistakes, or even to point a specific revision that already fixes (partially or entirely) this issue.

Best regards, João Marcos Costa

otavio commented 11 months ago

Hey @jmarcoscosta, have you performed any tests on other Systems on Chips (SoCs)?

jmarcoscosta commented 11 months ago

@otavio not really, as the A1 revision is the only one I have in hands.

angolini commented 11 months ago

I don't have access to any imx93 any longer, so I cannot test it on the board

otavio commented 11 months ago

Replaced by #1701

tprrt commented 8 months ago

Hello @otavio,

Can you backport these changes on the Kirkstone (LTS) branch?

Kind regards, Thomas

otavio commented 8 months ago

Please prepare a PR for this.

tprrt commented 8 months ago

Hello @otavio,

Please prepare a PR for this.

I'm preparing a pull-request to backport SoC revision support and sentinel firmware update, otherwise boards with new SoC revisions aren't usable with the Kirkstone (LTS) branch.

But what do you advise about Freescale EULA ?

Because the sentinel firmware v0.11 is using the EULA V48 that isn't available on the Kirkstone branch.

Kind regards, Thomas Perrot

otavio commented 8 months ago

Could it be added? we must confirm it does not break old recipes.

tprrt commented 8 months ago

Hello @otavio,

Moreover, it seems that the sentinel API has been modified since the 0.9 and the U-Boot 2022.04 used in the Kirkstone (LTS) branch doesn't use this new API.

So, to be able to use new SoC revision with the Kirkstone (LTS) it should be also necessary to update U-Boot or to backport patches adding the new sentinel API.

Kind regards, Thomas

ricardosalveti commented 8 months ago

We are using meta-freescale master with kirkstone (currently using based on the previous BSP rev, about to update to the latest), and it works fine with imx93 a1.

ricardosalveti commented 8 months ago

I believe not only u-boot, but optee might need to be updated as well, which is why backporting is a pain.

otavio commented 8 months ago

I'd rather avoid too invasive backports to reduce the risk of regressions.