Freescale / meta-freescale

Layer containing NXP hardware support metadata
Other
167 stars 254 forks source link

imx-oei: move to dynamic-layers and add arm-toolchain #1910

Closed hiagofranco closed 1 week ago

hiagofranco commented 2 weeks ago

The recipe depends on meta-arm-toolchain, therefore it should be on dynamic-layers/arm-toolchain folder. Create it and make the necessary changes for conf/layer.conf

Fixes: 61beaf5861f2 ("recipes-bsp: introduce imx-oei recipe")

otavio commented 2 weeks ago

@thochstein, could you ask internally why we need to use the arm toolchain instead of the general one? I'd prefer to drop that dependency and make the recipe general.

That would be done in a future release, but it would be nice to consider this improvement.

hiagofranco commented 2 weeks ago

I believe we can make this recipe conditional to the toolchain layer instead of the full arm layer. Could you give it a try?

https://git.yoctoproject.org/meta-arm/tree/meta-arm/conf/layer.conf

Either way, I marked the recipe to do the backport automatically, so once we merge this pull request, it's going to create automatically the backport pull request for us.

I am not sure if I got it correct, but I pushed the changes. Please have a look.

thochstein commented 2 weeks ago

@thochstein, could you ask internally why we need to use the arm toolchain instead of the general one? I'd prefer to drop that dependency and make the recipe general.

That would be done in a future release, but it would be nice to consider this improvement.

We need the generic compiler because the output runs on an m-core, not the main core.

github-actions[bot] commented 1 week ago

Successfully created backport PR #1930 for scarthgap.