search

Freeseer / freeseer

Designed for capturing presentations at conferences. Pre-fill a list of talks to record, record them, and upload them to YouTube with our YouTube Uploader.
http://freeseer.readthedocs.org
GNU General Public License v3.0
215 stars 110 forks source link

#516 test_multimedia.py creating "test.ogg.ogg" in the users video directory #525

Closed bohnje closed 10 years ago

bohnje commented 10 years ago

This fixes the issue where a file "test.ogg.ogg" was being created in the users video directory when running the test_multimedia.py. This code now sets the videodir as a temporary directory before executing the test. Setting the videodir before executing the test was implemented in aac07f1.

Link to issue: https://github.com/Freeseer/freeseer/issues/516

mtomwing commented 10 years ago

In your commit, the issue number should be referenced in the using a #. You can see the pattern we use with our commits. The rest of your commit message also isn't very descriptive as your fix doesn't just add a temp dir, it makes the test use a temporary videodir.

Otherwise your fix looks good and I can merge it once the commit message if fixed.

bohnje commented 10 years ago

I believe I fixed up the commit message, let me know if there is still something that needs to be improved with it.

mtomwing commented 10 years ago

What about:

Fix #516 Use a temporary videodir for recording tests
bohnje commented 10 years ago

Changed it to that. Whoops looking back at the previous message I realise it was still really non-descriptive. I thought the message I had changed it to mentioned that it was the video directory that was being set as a temporary directory but I must have imagined that.

mtomwing commented 10 years ago

Merged. Thanks for your contribution.