search

Freeseer / freeseer

Designed for capturing presentations at conferences. Pre-fill a list of talks to record, record them, and upload them to YouTube with our YouTube Uploader.
http://freeseer.readthedocs.org
GNU General Public License v3.0
215 stars 110 forks source link

Youtube API documentation (WIP) #536

Closed MadMub closed 9 years ago

MadMub commented 10 years ago

This PR will provide documentation on usage of the new Youtube Uploader, the documentation will be on the official freeseer-docs and no longer exist as the Google Doc.

Closes #463

dideler commented 10 years ago

I understand why the other inactive PRs were closed, but not why this one was closed.

MadMub commented 10 years ago

It will not be done for tomorrow, so I am just going to update the google doc, I guess for now we can redirect the youtube uploader page to the Google doc On Apr 7, 2014 7:30 PM, "Dennis Ideler" notifications@github.com wrote:

I understand why the other inactive PRs were closed, but not why this one was closed.

Reply to this email directly or view it on GitHubhttps://github.com/Freeseer/freeseer/pull/536#issuecomment-39796315 .

zxiiro commented 10 years ago

@MadMub do you plan on finishing it after the course?

If so leaving the PR open is fine.

MadMub commented 10 years ago

Yeah I plan on finishing it in April or may, I was just trying to make it clear which PRs I was considering to be merged by tomorrow, so you guys don't waste time looking at the incomplete stuff. On Apr 7, 2014 8:15 PM, "Thanh Ha" notifications@github.com wrote:

@MadMub https://github.com/MadMub do you plan on finishing it after the course?

If so leaving the PR open is fine.

Reply to this email directly or view it on GitHubhttps://github.com/Freeseer/freeseer/pull/536#issuecomment-39799071 .

zxiiro commented 10 years ago

As long as it's clear that it's not ready it's fine. What I usually do is set the subject to (Work In Progress).

MadMub commented 10 years ago

@dideler @zxiiro I will reopen the streaming and the docs PR, for the sake of you guys seeing whatever work was put into it for when you are evaluating, but don't bother doing code review on them. On Apr 7, 2014 8:21 PM, "Alex Pilon" apilo088@gmail.com wrote:

Yeah I plan on finishing it in April or may, I was just trying to make it clear which PRs I was considering to be merged by tomorrow, so you guys don't waste time looking at the incomplete stuff. On Apr 7, 2014 8:15 PM, "Thanh Ha" notifications@github.com wrote:

@MadMub https://github.com/MadMub do you plan on finishing it after the course?

If so leaving the PR open is fine.

Reply to this email directly or view it on GitHubhttps://github.com/Freeseer/freeseer/pull/536#issuecomment-39799071 .

dideler commented 10 years ago

@MadMub if you don't plan on working on a PR for a while or it's been inactive, it's a good idea to leave a comment saying so and closing the PR. It's less overhead for you and the project. Such a PR can easily become active again by reopening the PR.

This documentation PR was still semi-active I thought, since it's closely related to your ongoing PRs about the YouTube uploader which are about to merged. Hence my confusion.

If a PR is not ready to be merged, it's better to say it's a work in progress, like Thanh mentioned (e.g. "WIP: YouTube API docs") or leave a comment saying it's not ready if the due date is reached.

dideler commented 9 years ago

Cleaned it up and merged as a374c4395f98ea6451fd0fd1ff1023ba67d9ef54. Note that YouTube docs are still outdated as this PR was a WIP.