Open jameskunjoolee opened 10 years ago
Nice find. Perhaps it would be better to have the test failing since it turns out that the parser has issues. Would you or @jh0720 be interested in further investigating the issue?
The test now fails - presentation_feed.json
now contains the expected result. After testing cli.py
I can try looking into this issue.
@jameskunjoolee please do investigate, I've assigned you to the issue.
I recommend putting the CLI tests on hold on upping the priority on this. Tests let us discover issues like this, and when a test fails, the problem should be fixed as soon possible (all tests should be passing).
@jameskunjoolee to respond to your question on IRC, the branch for this fix should be based off of upstream/master, not your rss testing branch. The fix is independent of the tests.
Update:
It looks like the offset here: https://github.com/Freeseer/freeseer/blob/master/src/freeseer/plugins/importer/rss_feedparser/__init__.py#L112 is part of the problem.
This offset works for content that is not separated by <br />
tags.
There are two instances in which the parser does not grab the entire content of a feed. They are both lists.
Instance 1
Expected:
Actual:
Instance 2
Expected:
Actual:
Relevant: #506.