Closed FranciscoCanas closed 9 years ago
Can you move the issue references from the PR title to the PR description? It's more convenient that way since you'll be able to click them or hover over them to see which issue they refer to.
It's also a good idea to add a "Closes <issue number" at the bottom of the PR description, so it auto-closes the related issue when this gets merged.
@FranciscoCanas is this PR ready to be merged on your end? I'm unsure because the title still says WIP.
Not yet. I had asked him to look into using capsys
to replace the repeated stdout
capturing code.
Looks good. You're probably all ready to squash your commits. Only thing I'm unsure of is if you should include the issue # in the summary part of the commit message. Maybe @zxiiro can chime in on this.
Thanks for your contribution!
Refactoring tests as per the suggestions in #517.
Closes #562