#562 Refactoring YouTube tests.

Freeseer / freeseer

Designed for capturing presentations at conferences. Pre-fill a list of talks to record, record them, and upload them to YouTube with our YouTube Uploader.

http://freeseer.readthedocs.org

GNU General Public License v3.0

215 stars 110 forks source link

#562 Refactoring YouTube tests. #565

Closed FranciscoCanas closed 9 years ago

FranciscoCanas commented 10 years ago

Refactoring tests as per the suggestions in #517.

Comparing expected sample video metadata to metadata retrieved from video file.
Tests to use parametrized test functions.

Closes #562

dideler commented 10 years ago

Can you move the issue references from the PR title to the PR description? It's more convenient that way since you'll be able to click them or hover over them to see which issue they refer to.

It's also a good idea to add a "Closes <issue number" at the bottom of the PR description, so it auto-closes the related issue when this gets merged.

dideler commented 9 years ago

@FranciscoCanas is this PR ready to be merged on your end? I'm unsure because the title still says WIP.

mtomwing commented 9 years ago

Not yet. I had asked him to look into using capsys to replace the repeated stdout capturing code.

mtomwing commented 9 years ago

Looks good. You're probably all ready to squash your commits. Only thing I'm unsure of is if you should include the issue # in the summary part of the commit message. Maybe @zxiiro can chime in on this.

mtomwing commented 9 years ago

Thanks for your contribution!