search

Freeseer / freeseer

Designed for capturing presentations at conferences. Pre-fill a list of talks to record, record them, and upload them to YouTube with our YouTube Uploader.
http://freeseer.readthedocs.org
GNU General Public License v3.0
215 stars 110 forks source link

Add tip for Windows install to Quick Start guide #570

Closed farazs closed 9 years ago

farazs commented 9 years ago
farazs commented 9 years ago

If I remove the | s, line breaks happen in the middle of the paths, is that okay?

Note: I think whether this happens or not depends on your system resolution (size of the browser window).

dideler commented 9 years ago

@farazs you're right that it depends on the size of the window. In most cases the path should display fine, so I think it's better to remove the line breaks.

dideler commented 9 years ago

@farazs you can make the paths smaller with some modifications, e.g. <version> instead of <version_num>.

farazs commented 9 years ago

@dideler Alright, I shortened the paths and removed the second bullet (I don't actually know how to install that plugin).

dideler commented 9 years ago

@farazs can you update the PR description so it's accurate, and then also rewrite the summary line of your commit message so it's more descriptive? Often developers only look at the summary line, so it should be as descriptive as possible while still being concise. Something like "Add tip for Windows install to Quick Start guide" is a lot more descriptive than "Improved quick-start documentation" - then you can go into more detail in the commit message details.

farazs commented 9 years ago

@dideler Okay I made the changes. Does it look alright now?

dideler commented 9 years ago

Thanks!