Configtool Update Recording Tab

[farazs]

fixes #540

• [x] Moved directory selection to recording tab
• [x] Added recording tab heading
• [x] Other refactoring (renaming variables to match style)
• [x] Replace directory edit button text with "Browse..."
• [x] Translation support for the various changes

Note: There is a slight alignment issue caused by these modifications in the General tab because of the way ConfigTool is setup, everything in the different tabs is right-aligned unless it is forced to be left-aligned by something like a QLineEdit.

[dideler]

This is a great start! I'm going to review this in more depth tomorrow night by looking at the code changes.

Some quick feedback for this image so it matches the mockup:

• Try making the labels with the checkboxes stand out more since they're basically section headers and should be easy to spot. A slightly larger font size and maybe bold?
• Indent the content in the sections to align with the wording in the section header, instead of aligning with the checkbox. This visual cue makes it slightly more obvious that the content belongs to a group. Though I notice that there is a very light border, so this change may not be necessary once the above change to make the section header more obvious is completed.
• I'm not sure if it's necessary to stretch out the content with the window width. This pushes the setup and browse buttons very far to the right, which is less convenient for the user.

[farazs]

Alright so I made the section headers slightly larger and bold for both the Recording and General tab. Let me know if you feel this also resolves the second issue you brought up.

Looking into the stretching now.

[farazs]

I've made the widgets in the recording tab a fixed size. I'm not sure if this is the right way to go about the stretching issue. It seems that because of how the ConfigToolWidget is set up, the right panel automatically follows the right edge of the config tool. This alignment issue might be more related to #541

[zxiiro]

As you may have discovered Qt resize rules are determined by a few Qt policies.

QtSizeHint: http://qt-project.org/doc/qt-4.8/qt.html#SizeHint-enum QtSizePolicy: http://qt-project.org/doc/qt-4.8/qsizepolicy.html

And QLayout (along with the other layout classes that inherit it): http://qt-project.org/doc/qt-4.8/qlayout.html

[dideler]

Please post new screenshots whenever you make noticeably significant changes to the UI. Saves everyone else a lot of time from having to run your code locally to view the UI.

[farazs]

Oh alright. Sorry about that.

Here it is:

I ended up using NAME.capitalize() for the AboutWidget. It only capitalizes the first letter.

[farazs]

Thank you Thanh. I was mainly looking at SizePolicy, but I will look into SizeHint as well. It seems to be working well just with the SizePolicy changed to fixed and then changing the fixed size.

Are there any other changes that need to be made before this is good to go? Should I remove the changes regarding the AboutWidget minor refactoring and put those in a different pull request? Or should I just make that a separate commit when I squash the commits?

[dideler]

This is looking pretty good.

Alright so I made the section headers slightly larger and bold for both the Recording and General tab. Let me know if you feel this also resolves the second issue you brought up.

I noticed that I don't see the border for the groups on Ubuntu, I guess it's specific to Windows? So the alignment would still be a useful addition.

Are there any other changes that need to be made before this is good to go?

Alignment is broken for me in the Recording and General tabs (including the close button).

I'd like to see that fixed before merging this.

[farazs]

Here are the close button modifications :

[dideler]

Thanks. I saw in the IRC log that alignment with the section headers was difficult, so let's just drop it for now. Having it neatly aligned would make the UI more polished, but there's other stuff to do that can have more impact.

I'll take a look at the code changes now.

[dideler]

After you've responded to the feedback, you can squash the commits (you can use more than a single commit if you think some stuff doesn't belong in the same commit).

[farazs]

Okay I put the stylesheet into a variable called boxStyle. I put the dimensions into boxWidth and boxHeight. So they're not repeated multiple times.

I squashed the commits into one. Made it about Improving the ConfigTool as a whole so that some of the other minor changes can be put into it.

[dideler]

You're referencing the wrong issue in the commit message summary line. Should be #540, not #574 (which is the PR itself).

If the dimensions are constants (which I assume they are), the Python convention is to use ALL_CAPS for the name.

[farazs]

Ah okay thanks! That should be cleared up now.

[dideler]

Anyone else want to review before this gets merged?

[farazs]

Okay I switched the QLabel to a QSpacerItem, put a new line between the end of the else clause and the next statement, and only wrapped lines that went past 120 chars.

[zxiiro]

+1

Thanks

[dideler]

Merged as 6b5c1eabd90c430670cfbe63f98d827db4f4b396, thanks!