search

Freeseer / freeseer

Designed for capturing presentations at conferences. Pre-fill a list of talks to record, record them, and upload them to YouTube with our YouTube Uploader.
http://freeseer.readthedocs.org
GNU General Public License v3.0
215 stars 110 forks source link

Fix typo #582

Closed Cryspia closed 9 years ago

Cryspia commented 9 years ago

Fix the typo at line 628 of /frontend/record/record.py From starTime to startTime

Fix #581

dideler commented 9 years ago

Thanks @Promm.

Can you fix your git config so it uses your real name? We can't easily use nicknames legally (obligatory "I am not a lawyer / this is not legal advice / don't sue me" disclaimer).

Can you also improve the commit message? A simple "Fix #581 typo starTime -> startTime" should do. It's good to have a summary in the summary line (first line of the commit message) in addition to an issue reference. It's also not necessary to reference the line number since it shows in the diff.

You can rewrite the commit message with git commit --amend and then force pushing.

dideler commented 9 years ago

Thanks!

In the future, please let us know when you respond to feedback in the Pull Request (PR) so we can get it merged quicker. We don't get a notification when you push changes (since you're pushing to your fork), which is why a comment in the PR works best to notify us.

I noticed your name in git is now "KaiyuanLi", which is good enough for me to merge the patch, but you may still want to add a space between your first and last name.

For future PRs, you should use a more descriptive branch name (The "Report-Bug" in "581-Report-Bug" doesn't describe the branch very well) and a more descriptive PR title than "Fix #581" (try and give a short summary of the proposed changes).

dideler commented 9 years ago

Merged as c8b90d5c1cce2ceb8f318c0b369164b74bd85e46