search

Freeseer / freeseer

Designed for capturing presentations at conferences. Pre-fill a list of talks to record, record them, and upload them to YouTube with our YouTube Uploader.
http://freeseer.readthedocs.org
GNU General Public License v3.0
215 stars 110 forks source link

Fix #584 unicode string format error, 'string' to u'string' #585

Closed Cryspia closed 9 years ago

Cryspia commented 9 years ago

Fixes #584 This PR fix the bug that happens when change the interface into a unicode language (Janpanese/Chinese). The former version record.py would just crash when meeting this situation.

dideler commented 9 years ago

Please describe in the Pull Request description why this fix is needed. It's good practice.

Note that I added "Fixes #584" to your PR description. You should do this as well for your future PRs. Having issue references are very useful. I added that reference because I was reading issue #584 but there was no evidence of a PR from that issue's page. With the reference added here, it also shows up on the issue page.

Cryspia commented 9 years ago

Sorry. I did not notice that. I though that the reference link to this PR in the issue page should be enough. I will add more description for the reason.

dideler commented 9 years ago

Merged as b4a9a0e844d07c11ae9186f96bf97abcd8c08ab4, thanks!