Closed FranciscoCanas closed 9 years ago
I got the 1.9 version from what was listed under freeseer/docs/requirements.txt. But now that I did a 'pip show sphinx', it shows 1.1.3 installed on my system. I'll go ahead and change it to 1.2.3 in the requirements file.
Great. It's probably also worth removing the sphinx install thing from Travis.yml since it gets installed through pip.
Merged in 9f0a08adb0acf9988f52121f1d38918b2e653856.
Thanks for your contribution!
Where did you get version 1.9 from? It looks like the latest one on pypi is 1.2.3.
I did this so we get updates without worrying about breaking changes (since major version doesn't change).
@FranciscoCanas you forgot to update docs/README, can you open a new PR for that?
@dideler Yes, i'll update the docs/README and open a new PR. Should that README still have instructions on installing Sphinx? Are there situations where a user would want to build the documentation even though they aren't necessarily contributing, and so don't have dev_requirements installed?
@FranciscoCanas something like this would be good enough:
Sphinx should already be installed if you set up Freeseer for development, as Sphinx is listed as a dependency in [dev_requirements.txt](this should link to the file). You can also install Sphinx by following the official instructions.
Where did you get version 1.9 from? It looks like the latest one on pypi is 1.2.3.