search

Freeseer / freeseer

Designed for capturing presentations at conferences. Pre-fill a list of talks to record, record them, and upload them to YouTube with our YouTube Uploader.
http://freeseer.readthedocs.org
GNU General Public License v3.0
215 stars 110 forks source link

Fix #575 - Added Sphinx to the dev_requirements.txt file. #593

Closed FranciscoCanas closed 9 years ago

mtomwing commented 9 years ago

Where did you get version 1.9 from? It looks like the latest one on pypi is 1.2.3.

FranciscoCanas commented 9 years ago

I got the 1.9 version from what was listed under freeseer/docs/requirements.txt. But now that I did a 'pip show sphinx', it shows 1.1.3 installed on my system. I'll go ahead and change it to 1.2.3 in the requirements file.

mtomwing commented 9 years ago

Great. It's probably also worth removing the sphinx install thing from Travis.yml since it gets installed through pip.

mtomwing commented 9 years ago

Merged in 9f0a08adb0acf9988f52121f1d38918b2e653856.

mtomwing commented 9 years ago

Thanks for your contribution!

dideler commented 9 years ago

Where did you get version 1.9 from? It looks like the latest one on pypi is 1.2.3.

I did this so we get updates without worrying about breaking changes (since major version doesn't change).

@FranciscoCanas you forgot to update docs/README, can you open a new PR for that?

FranciscoCanas commented 9 years ago

@dideler Yes, i'll update the docs/README and open a new PR. Should that README still have instructions on installing Sphinx? Are there situations where a user would want to build the documentation even though they aren't necessarily contributing, and so don't have dev_requirements installed?

dideler commented 9 years ago

@FranciscoCanas something like this would be good enough:

Sphinx should already be installed if you set up Freeseer for development, as Sphinx is listed as a dependency in [dev_requirements.txt](this should link to the file). You can also install Sphinx by following the official instructions.