Closed dideler closed 9 years ago
+1
An improved theme would make our docs look really nice.
Assign this one to me. Thx!
@umcsdon I sent you an invite to be added to a Freeseer team, we need to do this to be able to assign issues to you. Once you accept we can assign the issue. Thanks.
Hi, @dideler @zxiiro . I have the initial version ready, take a look at here.
Any additional changes required? The commit can be found in my forked version with branch name: 596-bootstrap-theme.
Note: #571 problem still exists
Was there any custom CSS added to the bootstrap theme? It doesn't really feel like standard bootstrap.
Maybe something like this would look better.
Hi, @mtomwing . I didn't add any custom CSS written by me for this initial implementation.
However, I'm using the Flatly theme from bootswatch.com (Link)
Hi, @mtomwing. I think you are talking about sphinx_rtd_theme.
@dideler @zxiiro Which theme should we use?
@umcsdon Hey thanks a lot for jumping on this one!
After taking a look at both themes I'm leaning towards the sphinx_rtd_theme. I feel like it fits more naturally with the flow of reading docs than the sphinx-bootstrap-theme.
@zxiiro Sphinx_rtd_theme version is ready! Link
Any additional changes required?
@umcsdon if we build the docs locally, do we also get this theme?
@mtomwing I've added sphinx_rtd_theme to requirements.txt. After running pip install -r requirements.txt, you should able to see the changes.
You can checkout my forked version to see it.
Would be easier to see in a pull request.
@mtomwing Pull request ready.
+1 to the RTD theme, looks pretty good. Only drawback is that it looks like every other RTD site, but that's not a big deal.
Curious, does the styling of the navigation look different for anyone else when viewing the RTD theme locally?
Online
Local
@dideler I have the same problem.
@dideler I found the problem for the display color issue. In ../_template/layout.html, we manually set the color for a few tags.
I think this problem also explains the footer bug on the buildthedocs site, the ../_template/layout.html gets ignored there.
@dideler Should I remove those custom styling?
@umcsdon sure, give it a try. Those custom styles are specific to the current theme, so they won't be necessary if we switch themes.
https://github.com/ryan-roemer/sphinx-bootstrap-theme