Freeseer / freeseer

Designed for capturing presentations at conferences. Pre-fill a list of talks to record, record them, and upload them to YouTube with our YouTube Uploader.
http://freeseer.readthedocs.org
GNU General Public License v3.0
216 stars 110 forks source link

About the auto language changing and the config default language. #601

Closed Cryspia closed 9 years ago

Cryspia commented 9 years ago

I am still working on the auto language changing according to the system environment. But I found that it has some conflicts with the default language setting in the configuration. Which one should have higher priority? If both of them are valid, which one would be functional? If the auto language changing is no more needed, we can close issue #476.

mtomwing commented 9 years ago

I think this can go one of two ways:

  1. Auto detection is only used to determine the initial default value of the language config option (i.e. the language that's set if the user has no Freeseer config)
  2. Have a checkbox in the config tool that enables auto detection at startup (visually, it would also disable the language dropdown)
Cryspia commented 9 years ago

Personally I would prefer 1 because it seems more reasonable.

So my plan is to give the default language a special value if the user does not have the config file. By detecting that value, the auto language function will work. Otherwise, it will just use what ever language the user has saved.

It that OK?

mtomwing commented 9 years ago

Seems like a good plan. And FYI, the value you want to set is in freeseer.settings.

zxiiro commented 9 years ago

+1 for case 1.

dideler commented 9 years ago

It seems like this issue is really a question, which has been answered. Can it be closed now, or will #609 close it?

Cryspia commented 9 years ago

@dideler I think it can be closed now.

dideler commented 9 years ago

@Promm if an issue that you're the author of needs to be closed, GitHub should allow you to close it (instead of waiting for one of us to do it).