Configtool About tab update

[farazs]

Updated the layout of the "About" tab to be more similar to that of the newly changed "Recording" tab.

Windows:

Linux:

[farazs]

The one thing I wanted to change that I couldn't figure out how to do is that right now the About tab is the only tab in which the content moves when the window is resized. If I set the sizepolicy to fixed, it stops centering the content horizontally when the size of the window changes but still centers vertically.

[zxiiro]

Sorry, I haven't run this code but is About the default tab?

If it is, I think it shouldn't be the default tab. Maybe others have different opinions but I think about should be last in the list.

[dideler]

For comparison, here's how it currently looks.

[dideler]

@farazs I find your changes do make it look nicer. But the seer (i.e. the mascot) looks a bit squashed vertically.

[farazs]

@zxiiro I think it is. This change is just to make the appearance of the tabs more consistent. I could just move the about tab to the end, and then general would be the default tab.

@dideler Hmm, isn't this the same aspect ratio as the system tray logo?

I could (a) make the horizontal width smaller, so that the aspect ratio is close to the old one, and the logo is still aligned properly with the title. Alternatively, (b) I could increase the vertical height, and make it drop down toward the text.

[farazs]

[Committed and pushed these changes] Here's (a) : Windows:

Linux:

[farazs]

@zxiiro I've made the "About" tab the last tab and made "General" the default tab. Is this better? Edit: It seems it failed a test, that asserts that the "About" tab is the default tab.

[farazs]

Okay I edited the test to make it test for the General Widget being default. Note that I will be updating the general tab according to #539 so it won't look like it does currently.

[farazs]

I asked for opinions on the default tab in IRC and mtomwing said that he agrees "General" should be the default.

So if Dennis is okay with the new logo scale then this should be ready to squash and merge?

[dideler]

The logo isn't loading for me.

I'll try and investigate.

[farazs]

Ah you're right! That shouldn't be hardcoded. Fixed now.

[farazs]

Okay my Windows is returning 8 as the font size. Linux is returning 10. So when I try 110 px (using pt seems to make no difference) it's perfect for Windows but it's too little for Linux. So far that makes sense.

Your screenshots for 110 pt and fontSize * 10 look the same so I'm guessing your fontSize is returning 11. What I don't understand is how my Linux with a smaller font size needs more displacement than yours.

With 110 pt margin-left: Windows: Linux:

[jshyeung]

It might be due to other systems settings, try replacing it with a faction of the frontsize instead of hard coding a number.

[farazs]

Just pushed a new formula that I hope will look alright on other systems. It's partially hardcoded and partially fontSize based since neither of those two on their own were working.

[dideler]

I'm guessing your fontSize is returning 11

That's right.

Using the latest changes:

I think that's good enough.

[farazs]

Alright, squashed the commits. Let me know if there's anything else that needs to be changed before this is merged.

[dideler]

:shipit: