Freeseer / freeseer

Designed for capturing presentations at conferences. Pre-fill a list of talks to record, record them, and upload them to YouTube with our YouTube Uploader.

http://freeseer.readthedocs.org

GNU General Public License v3.0

215 stars 110 forks source link

#571: Fix footer broken #607

Closed umcsdon closed 10 years ago

umcsdon commented 10 years ago

According to Sphinx document, we have to call {{ super() }} in order to render extended template.

dideler commented 10 years ago

Hey @umcsdon, thanks for the Pull Request!

Unfortunately this doesn't fix the issue, so I'll go ahead and close this PR, but feel free to re-open if you find the fix.

571 doesn't contain much info, but this image should help explain the problem.

The call to super() makes the lower (default) footer appear, but we don't want that one. In fact, this is the footer that appears on our RTD site and that's what this issue is about.

We want the top (custom) footer. It works fine when you build the docs locally and when we were on GitHub Pages, so RTD is probably overriding our footer code. This is how it should look:

umcsdon commented 10 years ago

Hey @dideler , thanks for the explanation.

I will try to look into this problem during weekend. Could you please assign #596 to me as well?

dideler commented 10 years ago

@umcsdon I've assigned #571 and #596 to you :)

As for this issue, it might be difficult to debug since the problem only exists on RTD and you don't have build permissions to update the live docs to see if your fix works. But I can build a version of the docs to test your fix if you have a PR open (or you can host your own temporary copy of the docs on RTD to debug).

If you look around, you might find a solution if anyone else had the same problem, or you can ask @readthedocs for suggestions.