resolve #596: sphinx rtd theme - Githubissues

Freeseer / freeseer

Designed for capturing presentations at conferences. Pre-fill a list of talks to record, record them, and upload them to YouTube with our YouTube Uploader.

http://freeseer.readthedocs.org

GNU General Public License v3.0

216 stars 110 forks source link

resolve #596: sphinx rtd theme #611

Closed umcsdon closed 9 years ago

dideler commented 9 years ago

Hey @umcsdon, a few things before we can merge this:

The sphinx_rtd_theme dependency should go in dev_requirements.txt
Squash the commits into one (you'll need to do an interactive rebase, choose the commit to squash, and then force push your branch)
Add "Close #596" or "Fix #596" to the PR description and commit message summary
Add a short description to the PR explaining what changes are being introduced and why
Respond to feedback from code review

Thanks for helping out, we appreciate it.