benbuckley
commented
9 years ago I can think of a couple ways to add functionality to the window.
The issue is this. There are several cases where the user might need to be prompted to save/discard unsaved details to a talk: they might be (a) selecting a new talk, (b) exiting the talk editor, or (c) creating a new talk. In each case, the buttons "Save Changes", "Discard Changes" and "Continue Editing" should do slightly different things.
I have a couple ideas for solutions, each of which seems a little odd to me. I wanted to get some idea whether you had a preference either way:
(1) Have a separate SavePromptWidget for each of the 3 cases, and write a function for each of the 3 buttons, up to 9 functions in total. For example, closing the window would bring up a widget called something like savePromptWidgetClose and clicking "Save Changes" in that window would call a function called something like click_save_button_close.
(2) Have only one SavePromptWidget -- however, rewrite the functions for "Save Changes", "Discard Changes" and "Continue Editing" depending on which function is called. For example, there might be some code in the __init__() function that looks something like this:
self.click_save_button = lambda: None
self.click_discard_button = lambda: None
self.click_continue_button = lambda: None
self.connect(self.savePromptWidget.saveButton, SIGNAL('clicked()'), self.click_save_button)
self.connect(self.savePromptWidget.discardButton, SIGNAL('clicked()'), self.click_discard_button)
self.connect(self.savePromptWidget.continueButton, SIGNAL('clicked()'), self.click_continue_button)... and there would be some code in click_add_button() that would look something like this:
if self.unsaved_details_exist(self):
def new_click_save_button(self):
# Do whatever I want the save button to do
self.click_save_button = new_click_save_button # Changes the function itself
# Do the same for click_discard_button and click_continue_buttonSimilarly, click_talk() and closeEvent() would set their own versions of click_save_button(), click_discard_button() and click_continue_button() before making the widget visible.
Some of the syntax above might be a little wrong, but in principle I know it's possible to do this kind of thing in Python. I kind of like solution 2, probably because I write a lot of Lisp programs in my spare time, and it's not uncommon in Lisp to be this cavalier about treating functions like data. I started writing it this way, but before I got too far, I thought I should consult the mentors and the PEP8 guide. The PEP8 guide doesn't have anything nice to say about using lambda, and a quick search for the word "lambda" in the repository only brings up a couple of fairly simple, probably very routine examples, so I was hesitant to program it in such an unconventional way.
Thoughts, @zxiiro or @dideler ?
dideler
Now that PR #605 has been merged, I would like to add some tests for the new functions I created. I will have a better idea of what steps this requires as I start experimenting, but I thought I should create this PR as soon as possible. Ultimately, this should close issue #630 .
Oct. 20, 2014: After some research, I have a slightly better idea of what I need to accomplish. These tasks might change as more information comes along -- I haven't even learned about QtTest yet.
Oct 29, 2014: After further thinking, it might not be worth it to focus on upgrading everything to Pytest just yet. For the time being, I mostly just want to get some tests done. So, I'm putting the Pytest goals on hiatus.