search

Freeseer / freeseer

Designed for capturing presentations at conferences. Pre-fill a list of talks to record, record them, and upload them to YouTube with our YouTube Uploader.
http://freeseer.readthedocs.org
GNU General Public License v3.0
215 stars 110 forks source link

Refactor and add tests for plugins.py #642

Closed SRomansky closed 9 years ago

SRomansky commented 9 years ago

Improvement to the tests currently being run on plugins.py

related #644

dideler commented 9 years ago

count_platform_plugins_in_directory looks like an expensive operation and is called quite a bit. How long does it take for these tests to run? edit: consider caching the values

SRomansky commented 9 years ago

On my laptop before caching the tests took 1.07 seconds to run, after caching 1.03 seconds. With a HDD the time difference would probably be even larger.

dideler commented 9 years ago

I think this is close to being merge-ready. Can you squash your commits?

dideler commented 9 years ago

Is this good to go on your end? If so, please squash again.

SRomansky commented 9 years ago

squashed

dideler commented 9 years ago

Please fix your commit message to use proper issue referencing, see http://freeseer.readthedocs.org/en/latest/contribute/basics.html#reference-issues-in-your-commit-messages. The formatting you're using is only recognized by our IRC bot.

SRomansky commented 9 years ago

Fixed, sorry about that.

dideler commented 9 years ago

Merged as e1d1c4256293caa31f44c16b65fd6ffdd5a02b78, thanks @wigglier.