search

Freeseer / freeseer

Designed for capturing presentations at conferences. Pre-fill a list of talks to record, record them, and upload them to YouTube with our YouTube Uploader.
http://freeseer.readthedocs.org
GNU General Public License v3.0
215 stars 110 forks source link

Fixes 658: Error during startup for windows missing plugin #660

Closed FranciscoCanas closed 9 years ago

FranciscoCanas commented 9 years ago

Fixes #658: Error during startup for windows missing plugin

I have moved the calls to get_default_device() methods into the affected plugins' get_videoinput_bin() (get_audioinput_bin() for Pulsesrc) methods. This ensures that get_default_device() is only called when the plugin actually gets used, instead of during freeseer initialization.

Previously, the Yapsy PluginManager was loading the plugin module during initialization, which was causing get_default_device() to run, which in turn calls a get_devices() method. In the case of Pulsesrc audio, get_devices() attempts to probe the plugin which doesn't exist in windows.

dideler commented 9 years ago

Can you move the issue reference from the PR title to the PR description (because it's not auto-referenced in the title) and also reference the issue in the commit message.

farazs commented 9 years ago

Confirmed that this fixes the issue on Windows

dideler commented 9 years ago

Merged as 7ed8fb61482d975b1c79225dd0dea3db5c01c8c4, thanks guys!