search

Freeseer / freeseer

Designed for capturing presentations at conferences. Pre-fill a list of talks to record, record them, and upload them to YouTube with our YouTube Uploader.
http://freeseer.readthedocs.org
GNU General Public License v3.0
215 stars 110 forks source link

Skip tests related to RTMP plugin for Windows #662

Closed Cryspia closed 9 years ago

Cryspia commented 9 years ago

The RTMP plugin is not included in GStreamer for Win32, so the test based on it can cause problems. This workaround will skip these tests.

Related to #647

Cryspia commented 9 years ago

The raw_data can be seen: http://promm.github.io/freeseer/doc/freeseer_test_skip_rtmp.txt It is a bit weird that the first five tests are all skiped for test_plugin.py (Should be only the 5th). Is there anything I got wrong?

Cryspia commented 9 years ago

I cannot find how the pytest.mark.skipif can deal with the system condition and the input condition together, so I just put the skip inside the test. Now it will skip only one test.

If this change does not fit the requirement. I will think about other ways.

The raw data is also updated.

Cryspia commented 9 years ago

@dideler Issue number referenced in the comment.

dideler commented 9 years ago

Thanks @Promm, merged as 91f3d7cd78f8be3a23020a4a31925e2cac0cfb8d.

I edited the PR and commit to remove any references that would auto-close the related issue, since this workaround does not fix the issue.