Fix #650: Resetting configuration raises error when file do not exist

Freeseer / freeseer

Designed for capturing presentations at conferences. Pre-fill a list of talks to record, record them, and upload them to YouTube with our YouTube Uploader.

http://freeseer.readthedocs.org

GNU General Public License v3.0

215 stars 110 forks source link

Fix #650: Resetting configuration raises error when file do not exist #669

Closed umcsdon closed 9 years ago

umcsdon commented 9 years ago

Fix #650

Completed

[x] Config file existence condition is checked before os.remove

zxiiro commented 9 years ago

Merged with 2a74681b

Thanks for the quick fix!

dideler commented 9 years ago

Just a note that asking for forgiveness is better than asking for permission when it comes to removing a file. Handling the exception is more defensive code because it avoids a possible race condition, that's why I gave the code example in #650.

I'll leave this fix as is, but something to keep in mind when coding a similar thing in the future.