Freeseer / freeseer

Designed for capturing presentations at conferences. Pre-fill a list of talks to record, record them, and upload them to YouTube with our YouTube Uploader.
http://freeseer.readthedocs.org
GNU General Public License v3.0
215 stars 110 forks source link

Fix PEP8 coding style violations (all but E501) #678

Closed habi closed 9 years ago

habi commented 9 years ago

I ran pep8 --ignore=E501 *.py and fixed some minor errors.

TODO: Fix E501 errors.

As part of http://24pullrequests.com/

zxiiro commented 9 years ago

We actually purposely ignore whitespace after : because it makes the code align better visually.

See out tox file at:

https://github.com/Freeseer/freeseer/blob/master/tox.ini

dideler commented 9 years ago

Hi David, thanks for helping out.

We use flake8 to check for PEP8 violations. You can see which rules we ignore in the tox.ini file.

# E127 - Over indentation
# E128 - Under indentation
# E221 - Multiple whitespace before operator
# E241 - Multiple whitespace after :
# E265 - block comment should start with '# '

Edit: Thanh said it first :)

habi commented 9 years ago

I thought the code alignment might be a visual issue :) Do you also ignore pep8s

E225 missing whitespace around operator

and

E121 continuation line indentation is not a multiple of four

Because [docs/source/conf.py]() contains some of those. Then I could still be of little help :)

dideler commented 9 years ago

@habi we run flake8 on the src/ directory so we don't catch any PEP8 violations in docs/.

If you narrow down your changes to just the docs I'll gladly merge this PR.

habi commented 9 years ago

There wasn't much to do, nonetheless I made [docs/source/conf.py]() fully pep8-compliant, see PR https://github.com/Freeseer/freeseer/pull/681