Closed mrobinet closed 8 years ago
Nice job! Had no clue there was something like this :) I've tested it and it works fine, the only issue now is that it won't work in offline mode and some people use it only offline. But I will add error handling so that if there's no connection it will load cards from a JSON-file (https://github.com/pdyck/hearthstone-db) and then I will merge your update.
This swaps loading card data from a file to loading it from http://www.hearthstoneapi.com/.
This would mean you would no longer have to keep the card data up to date, but I believe you'd still have to change the version to invalidate the local storage caching. Might be a good improvement to just have the local storage cache expire after a short time.