search

Freezard / hs-collection-tracker

Tracks your Hearthstone card collection.
https://hs-collection-tracker.glitch.me/
17 stars 6 forks source link

HearthPwn card tooltips #48

Closed Leonix closed 8 years ago

Leonix commented 8 years ago

Hey Freezard, thanks for an awesome tool!

This PL adds convenient card tooltips by HearthPwn. Preview here: http://leonix.github.io/hs-collection-tracker/

Unfortunately, this creates a liability to update local card database with cards ID as used by HearthPwn. I have found no way to avoid that. I myself grabbed data from Hearthstone Linkifier chrome extension. Kudos for the author.

Freezard commented 8 years ago

Hi and thanks for the feature! I've been thinking of adding this, but seems I forgot making it an issue.

Do you have any idea if the HearthPwn card IDs are the same as the card IDs from the game? In that case I can just add the IDs to the collection card data.

If you know a way to add a delay when hovering over the cards until the tooltips show up (like a 1 second delay), I think it would be less messy since you're kinda hovering over cards all the time.

And one problem: The tooltips stop working when you switch tab to ie progress and then back to the tracker, the site uses templates so you'd have to add the data-tooltip-hrefs each time the tracker template is switched to. But I can probably fix that myself.

Leonix commented 8 years ago

I don't think HearthPwn and in-game ids match. At least I see no similarities between all-collectibles.json and card-ids.json.

There's no imidiately available way to configure the tooltip script, at least no delay option. But I'm pretty sure it's possible with some monkey-patching. I'll look into that. (One second is way too much I think, though.)

And I'll fix bug with switching to a different tab, too.

Leonix commented 8 years ago

Delays and switching between tabs should work now.

Freezard commented 8 years ago

Awesome thanks a lot, will commit soon.

Freezard commented 8 years ago

Unfortunately I had to comment it out for now, it doesn't work on IE and on both IE and Edge it slows down the site so much when clicking around on cards/class tabs that it stops responding. Works fine on Chrome, haven't tested Firefox. You have any idea why this is?

On Tue, Apr 5, 2016 at 6:17 PM, Leonid Vakulenko notifications@github.com wrote:

Delays and switching between tabs should work http://leonix.github.io/hs-collection-tracker/ now.

— You are receiving this because you commented. Reply to this email directly or view it on GitHub https://github.com/Freezard/hs-collection-tracker/pull/48#issuecomment-205878764