Freezard / hs-collection-tracker

Tracks your Hearthstone card collection.
https://hs-collection-tracker.glitch.me/
17 stars 6 forks source link

Uncollectible cards in card-ids.json #69

Closed MatteoGrossele closed 7 years ago

MatteoGrossele commented 7 years ago

Inside the file card-ids.json ( used to gather hearthpwn ids) there are some uncollectible cards, mainly from the early sets (for example boom bots, gallywix coin, ...)

MatteoGrossele commented 7 years ago

I'm quite familiar with this file, I could fix this if you say these cards can be removed and they are not there for some extra feature. Also, since the attribute 'whid' is no longer obtainable because the hearthhead site changed, can this data be removed from all the cards in this file? I saw that it is never used.

Freezard commented 7 years ago

Hi yes, it would be good with some cleanup. Go ahead and remove whids too, they're not used, just leftovers from the original file.