search

FreezingMoon / AncientBeast-Website

All the source files of the Ancient Beast website 🐲
https://AncientBeast.com
GNU Affero General Public License v3.0
8 stars 8 forks source link

remove gaps between items #103

Closed DreadKnight closed 1 year ago

DreadKnight commented 2 years ago

On the contribution page, the icons on the right card (or the sections) shouldn't have any spacing between them, that way everything fits nicely within the card's frame instead of overlapping it at the bottom https://ancientbeast.com/contribute

Screenshot_20220813_045527

Dhananjay-12 commented 1 year ago

Hi , I guess I understood the problem. The icons are behaving like this due the display: table-cell; in the wrapper class. If this resolves this can I fix this? Thanks

DreadKnight commented 1 year ago

Hi , I guess I understood the problem. The icons are behaving like this due the display: table-cell; in the wrapper class. If this resolves this can I fix this? Thanks

Heya! Sure thing, feel free to poke at it. I've assigned you to it, soft deadline 2 weeks.

Dhananjay-12 commented 1 year ago

hi, do you received the changes?

DreadKnight commented 1 year ago

hi, do you received the changes?

Heya! You need to make a pull request (PR) from your branch that gets reviewed after (testing, feedback, changes etc.) https://github.com/FreezingMoon/AncientBeast-Website/pulls

I see you made changes by commenting a line, usually just go ahead and remove that code line if you tested stuff. https://github.com/FreezingMoon/AncientBeast-Website/compare/master...Dhananjay-12:AncientBeast-Website:master

Dhananjay-12 commented 1 year ago

Thanks I made the changes. Made a PR too : ]

DreadKnight commented 1 year ago

Thanks I made the changes. Made a PR too : ]

Alrighty, left you feedback on the PR.

DreadKnight commented 1 year ago

Fixed in PR #111