search

FreezingMoon / AncientBeast-Website

All the source files of the Ancient Beast website 🐲
https://AncientBeast.com
GNU Affero General Public License v3.0
8 stars 8 forks source link

Update card.css #106

Closed Dhananjay-12 closed 1 year ago

Dhananjay-12 commented 1 year ago

Removed line 38 as it was causing the cells to have gap.

DreadKnight commented 1 year ago

I've tested this and it still looks off like before, needs more work and testing. Also, in PR description you should usually mention the open issue that you're trying to fix, like #103 in this case. I can see what you've done in the "Files changed".

Dhananjay-12 commented 1 year ago
Screenshot_20221126_112237
Dhananjay-12 commented 1 year ago

How about this ?

Dhananjay-12 commented 1 year ago

Well, I noticed now that those Icons have been position relative. But I guess using flexbox or grid might help. Can I try that?

DreadKnight commented 1 year ago
Screenshot_20221126_112237

That's the idea, but make sure the red outline on the other card stays in place as well. Also, modify css only to affect the contribution page, because the cards.css file is meant for this other page https://ancientbeast.com/documentation/?id=wars#skills as it has some cards in it (having a different issue atm it seems). Do the tweaks here: https://github.com/FreezingMoon/AncientBeast-Website/blob/master/contribute/index.php#L26