search

FreezingMoon / AncientBeast

The Turn Based Strategy Game/eSport. Master your beasts! 🐺
https://AncientBeast.com
GNU Affero General Public License v3.0
1.66k stars 571 forks source link

Properly inherit Phaser #1334

Open ktiedt opened 6 years ago

ktiedt commented 6 years ago

Move towards a more proper Phaser setup by inheriting Phaser.Game instead of storing it as a property.

There is likely some more that can be done, but this is a good 1st step.

ktiedt commented 6 years ago

I have a PR for this -- but it touches several ability files which now have to be fixed for the linter -- will commit tomorrow at some point :)

DreadKnight commented 6 years ago

Alright, sounds good. Looking forward to it :+1:

DreadKnight commented 6 years ago

@ktiedt wondering if you've made progress with this one :)

ktiedt commented 6 years ago

Have not had a chance to revisit, may have that opportunity sometime this week in the evening.

ktiedt commented 6 years ago

Just updating here -- this was bigger than I expected it to be, I am revisiting my bookmarks and code to refresh my memory on this and I'm gonna try and knock it out in the next week over several evenings.

DreadKnight commented 6 years ago

@ktiedt Alright, understood. Thanks for the update, I hope all goes well :)

ktiedt commented 5 years ago

I didn't forget about this. It's just that big of a pain - i suspect this ticket might just have to go un-fixed until you are willing to spend significant time on re-writing a bunch of the legacy stuff, as this fix blows up a bunch of things :(