FreezingMoon / AncientBeast

The Turn Based Strategy Game/eSport. Master your beasts! 🐺
https://AncientBeast.com
GNU Affero General Public License v3.0
1.67k stars 585 forks source link

audio related shortcuts behavior [bounty: 12 XTR] #1481

Open DreadKnight opened 6 years ago

DreadKnight commented 6 years ago

The A hotkey should open the Audio view, while Shift+A (or right clicking the icon) should toggle between the following 3 states, while also displaying the corresponding icons:

Icon style that we're using: no background, black 4px outline for the foreground elements. Need to be tweaked using the web tools, otherwise they increase in file size even if vacuumed.

This will enable track skipping by holding shift and tapping A hotkey or right clicking the Audio UI button 3 times.

The tooltip of the button should include info about this stuff overall, without being bloated.

These changes are in order to simplify and speed up the most used audio related actions.

zufishanali commented 4 years ago

Hi @DreadKnight , I would like to work on this.

DreadKnight commented 4 years ago

@zufishanali Alrighty, assigned you to it! You have 2 weeks, good luck! :-)

DreadKnight commented 4 years ago

The Shift+A functionality was already added recently btw.

NRAM3SH commented 1 year ago

Hi @DreadKnight. I am part of a team working on a few hotkey related issues, including this one. My team has a forked repo that has the functionality to switch between audio states, but we are still working on the icon switching feature. Would it be possible to make a pull request of the code so that you could take a look at the current code status? Thanks!

DreadKnight commented 1 year ago

Hi @DreadKnight. I am part of a team working on a few hotkey related issues, including this one. My team has a forked repo that has the functionality to switch between audio states, but we are still working on the icon switching feature. Would it be possible to make a pull request of the code so that you could take a look at the current code status? Thanks!

Heya, @NRAM3SH ! I'll assign you to the issue. I've given this some thought a while ago but I was busy moving living place and didn't get to update the specs, see original post again as I've turned things around a bit, otherwise Audio view would remain hard to reach and become rather obscure. Note that this was meant for next milestone and was labeled as "brainstorm" before, meaning it wasn't meant to be worked on yet, but still cement down the design first before giving it the green light. These should be good enough specs I think, we'll see more given actual testing and feedback, but feel free to tweak and make a PR. Sorry about the fuss 🐻