FreezingMoon / AncientBeast

The Turn Based Strategy Game/eSport. Master your beasts! 🐺
https://AncientBeast.com
GNU Affero General Public License v3.0
1.66k stars 572 forks source link

ditch jQuery for UI+animation libs #1587

Open DreadKnight opened 4 years ago

DreadKnight commented 4 years ago

We should totally ditch jQuery and replace it with an UI library plus an animation one, some options:

Edit: Going with Vue/Tres frameworks.

DreadKnight commented 4 years ago

Or maybe keeping things native, using https://developer.mozilla.org/en-US/docs/Web/API/Web_Animations_API/Using_the_Web_Animations_API

andretchen0 commented 1 year ago

There's a lot of jQuery $.extend calls used to copy properties from one JS object to another. If it's simple values that are being copied, those can be replaced with native Object.assign. Otherwise, a relatively simple custom function could be used for deep copies.

Is that worth doing as an intermediate step in order to move towards this goal?

DreadKnight commented 1 year ago

There's a lot of jQuery $.extend calls used to copy properties from one JS object to another. If it's simple values that are being copied, those can be replaced with native Object.assign. Otherwise, a relatively simple custom function could be used for deep copies.

Is that worth doing as an intermediate step in order to move towards this goal?

Yeah, I guess so; if we decouple from the stuff without running into issues that's still progress.

DreadKnight commented 1 year ago

We'll be going the Vue/Tres route.