search

FreezingMoon / AncientBeast

The Turn Based Strategy Game/eSport. Master your beasts! 🐺
https://AncientBeast.com
GNU Affero General Public License v3.0
1.65k stars 566 forks source link

better showcase current unit location when moving [bounty: 6 XTR] #2129

Open DreadKnight opened 1 year ago

DreadKnight commented 1 year ago

When targeting new location for active unit, the current location should be showcased using colored dashed hexagons.

ysh113 commented 1 year ago

Hello, I would like to try to solve this. Can you please tell me where the file is located? Thank you

DreadKnight commented 1 year ago

Hello, I would like to try to solve this. Can you please tell me where the file is located? Thank you

Heya, @ysh113 ! Alright, will assign you to this (2 weeks soft deadline). Code might be this one, if not, probably in that file https://github.com/FreezingMoon/AncientBeast/blob/master/src/utility/hex.ts#L393

Aayush895 commented 1 year ago

Hello, is this issue still active? If it is I had some questions regarding the issue since I am a first-timer and I wanted to try and make my first contribution to this issue.

DreadKnight commented 1 year ago

Hello, is this issue still active? If it is I had some questions regarding the issue since I am a first-timer and I wanted to try and make my first contribution to this issue.

@Aayush895 Heya! Yeah, still up for grabs. Go ahead and ask.

Aayush895 commented 1 year ago

Hello, is this issue still active? If it is I had some questions regarding the issue since I am a first-timer and I wanted to try and make my first contribution to this issue.

@Aayush895 Heya! Yeah, still up for grabs. Go ahead and ask.

I was using the application and the question that I have regarding this issue is that when I want to move the character to a new location (or to any visible hexagons) or let's say that I am hovering on a new location then should the current location be showcased in dashed colored hexagons or when the character has moved to a new location only then the old location should be showcased in dashed colored hexagons? PS: Sorry if I framed the question poorly.

DreadKnight commented 1 year ago

Hello, is this issue still active? If it is I had some questions regarding the issue since I am a first-timer and I wanted to try and make my first contribution to this issue.

@Aayush895 Heya! Yeah, still up for grabs. Go ahead and ask.

I was using the application and the question that I have regarding this issue is that when I want to move the character to a new location (or to any visible hexagons) or let's say that I am hovering on a new location then should the current location be showcased in dashed colored hexagons or when the character has moved to a new location only then the old location should be showcased in dashed colored hexagons? PS: Sorry if I framed the question poorly.

First option, when you start the hovering process and have new possible coordinates for the active unit. That way even when you're trying to move medium (2 hexagons) or large (3 hexagons) unit just a bit inline (1-2 hexagons), you'll get a better idea of what's going on (well, what will happen if you click to confirm), so keep in mind that scenario when testing.