FreezingMoon / AncientBeast

The Turn Based Strategy Game/eSport. Master your beasts! 🐺
https://AncientBeast.com
GNU Affero General Public License v3.0
1.67k stars 579 forks source link

"canceled" temporary indicator after toggling abilities [bounty: 4 XTR] #2170

Closed DreadKnight closed 2 months ago

DreadKnight commented 1 year ago

When clicking the active's unit passive activity several times, togging through usable abilities and ending up canceling, a new icon should be temporarily displayed in a similar fashion to the one pointing at an ability below.

This is the icon that should be used https://github.com/FreezingMoon/AncientBeast/blob/master/assets/icons/cancel.svg

You can check out #2174 as well, as it's related.

andretchen0 commented 1 year ago

To clarify, for a priest, currently:

After this issue:

andretchen0 commented 1 year ago

Just to chime in, I think this is worth working on. I've been playing around with the game for a few weeks now now and I was confused by the passive ability button.

I wonder if it simply shouldn't be a button at all.

Maybe remove the button and put the icon/text bubble on the hover of the queue vignette? Like so:

normal hover
DreadKnight commented 1 year ago

Just to chime in, I think this is worth working on. I've been playing around with the game for a few weeks now now and I was confused by the passive ability button.

I wonder if it simply shouldn't be a button at all.

Maybe remove the button and put the icon/text bubble on the hover of the queue vignette? Like so:

normal hover

Button is needed, vital stuff shouldn't be hover only. Dota2 and other mobas display passive abilities all the time in between usable ones, with just a small difference in frame (being frameless usually) and unlike AB, without any predictable order; on top of that we got nice functionality for the button. I'll actually split this issue in two, see issue #2174 as well.

andretchen0 commented 1 year ago

Gotcha. Make sense.

with just a small difference in frame (being frameless usually)

I like the idea of making a different (or no) frame for passives.

Joywin2412 commented 2 months ago

I have reproduced this issue on Chrome webpage. I think I can work on this. Do assign this issue to me. @DreadKnight

DreadKnight commented 2 months ago

Sounds good. Will assing you to it.

On Sat, Aug 10, 2024, 5:45 PM Joywin Pinto @.***> wrote:

I have reproduced this issue on Chrome webpage. I think I can work on this. Do assign this issue to me. @DreadKnight https://github.com/DreadKnight

— Reply to this email directly, view it on GitHub https://github.com/FreezingMoon/AncientBeast/issues/2170#issuecomment-2282166066, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEPNX3D45XIZMR5RCU2DH3ZQYRR3AVCNFSM6AAAAABMJ4QC2SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBSGE3DMMBWGY . You are receiving this because you were mentioned.Message ID: @.***>