search

FreezingMoon / AncientBeast

Turn Based Strategy Game. Master your beasts! 🐺
https://AncientBeast.com
GNU Affero General Public License v3.0
1.63k stars 555 forks source link

Firefox warns about OpenCollective embed #2480

Open andretchen0 opened 11 months ago

andretchen0 commented 11 months ago

Since this merge, Firefox warns:

Partitioned cookie or storage access was provided to “https://opencollective.com/ancientbeast/tiers/sponsor.svg?avatarHeight=61&width=800&limit=10” because it is loaded in the third-party context and dynamic state partitioning is enabled.

... which reads awfully scary.

It's due to how the SVG is embedded. It's done as an <object>. You can load third-party SVGS as <img />.

CSS will need to be adjusted as it depends on #opencollective_banner > object.

It would be best to include the OpenCollective SVG data in the local assets. That allows it to be packed. And it avoids the SVG becoming a third-party "tracking pixel" for players – and devs!

To Reproduce

  1. Start a game in Firefox.
  2. Open console.
  3. See warning.

Expected behavior

No warning. No third-party tracking.

JoelFernandes09 commented 11 months ago

Can I take this one if it hasn't been started yet?

DreadKnight commented 11 months ago

@JoelFernandes09 Heya! Poke at some other issue for now please.