FreezingMoon / AncientBeast

The Turn Based Strategy Game/eSport. Master your beasts! 🐺
https://AncientBeast.com
GNU Affero General Public License v3.0
1.68k stars 585 forks source link

Added white hex outline on hovering round counter. #2491

Open dheerajd5 opened 1 year ago

dheerajd5 commented 1 year ago

This fixes issue #2240

Note: As of now I am calling the displayVisualState() function everytime for each hex in the grid, everytime showGrid()is called. I didn't notice much of a performance difference but I've put the results in the comments related to this issue.

This is what it looks like after adding the white hex. image

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ancientbeast ✅ Ready (Inspect) Visit Preview Aug 27, 2023 5:52pm
ghost commented 1 year ago
👇 Click on the image for a new way to code review #### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/FreezingMoon/AncientBeast/2491/96147c92/31f65e9184c3558b17a7268c3551016e6ae415f7.svg)](https://app.codesee.io/r/reviews?pr=2491&src=https%3A%2F%2Fgithub.com%2FFreezingMoon%2FAncientBeast) #### Legend CodeSee Map legend
DreadKnight commented 1 year ago

@dheerajd5 Heya! By "white outline" I didn't mean a new white hexagon (they tend to get edges overlapped at times), but css text effect for the letter-number coordinate, kinda like in this tut over here -> https://kinsta.com/blog/css-text-outline