search

FreezingMoon / AncientBeast

The Turn Based Strategy Game/eSport. Master your beasts! 🐺
https://AncientBeast.com
GNU Affero General Public License v3.0
1.66k stars 569 forks source link

feat: showcase branding in coordinate view [#2248] #2496

Closed cesardlinx closed 12 months ago

cesardlinx commented 12 months ago

I added the functionality of displaying the project logo in the background when hovering over the round marker or holding shift in order to trigger the hexagon coordinate view as you can see in the gif below. It shows up with a smooth transition as requested in the issue

ancient_beast

Closes #2248

My wallet address is 0xb2717FC8dFcc42A75E06A38aa273C0b9F4Cba848

vercel[bot] commented 12 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ancientbeast ✅ Ready (Inspect) Visit Preview Oct 2, 2023 4:26pm
ghost commented 12 months ago
👇 Click on the image for a new way to code review #### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/FreezingMoon/AncientBeast/2496/ceec9a67/be649d3600681d3143592772c11ca5380da8fdb4.svg)](https://app.codesee.io/r/reviews?pr=2496&src=https%3A%2F%2Fgithub.com%2FFreezingMoon%2FAncientBeast) #### Legend CodeSee Map legend
DreadKnight commented 12 months ago

@cesardlinx Heya! The "top" as em is bad, if you make the screen smaller you'll see why. It should use px and be a little bit under the unit queue avatars.

cesardlinx commented 12 months ago

@DreadKnight I see what you mean, please give it a look now. This is how it is looking. I changed it to px and I moved the brand a little bit under the queue as suggested.

ezgif com-optimize (1)

Let me know what do you think

DreadKnight commented 12 months ago

@cesardlinx Did more testing, some issues:

  1. Left side of the UI shouldn't be pushed down.
  2. Logo should also scale down as well with game. The idea is to not have logo ever overlap hexagons. I've been scaling game diagonally unlike your testing.
cesardlinx commented 12 months ago

@DreadKnight Got it! lol I didn't noticed the left side sorry. I fixed all the mentioned issues. Give it a look, let me know what do you think

cesardlinx commented 12 months ago

@DreadKnight Hey! Sorry I couldn't share the gif previously of how it looks but here it is

ancient_beast_brand6

DreadKnight commented 12 months ago

@cesardlinx Alright, looks pretty ok now. No worries, gifs are always nice, but fully optional. Merged and sent bounty 🪙

cesardlinx commented 12 months ago

Cool! 👌