FreezingMoon / AncientBeast

The Turn Based Strategy Game/eSport. Master your beasts! 🐺
https://AncientBeast.com
GNU Affero General Public License v3.0
1.66k stars 569 forks source link

Fix for Upgraded Seismic Stomp Visual Behavior, issue 2125/2126 #2510

Closed xTammaro closed 11 months ago

xTammaro commented 11 months ago

Fix for Upgraded Seismic Stomp Visual Behavior

This fixes issue #2125 and potentially #2126. The new visual behaviour for Seismic Stomp upgraded ability:

https://github.com/FreezingMoon/AncientBeast/assets/71015951/4d667d76-73da-4cdf-acbe-f05fa034d4d6

The changes include:

Only filling in the hexes of the creature that is hovered

Showing dashed hex for empty hexes

Cancelling the ability upon clicking the empty hex.

vercel[bot] commented 11 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ancientbeast ✅ Ready (Inspect) Visit Preview Oct 17, 2023 4:47am
ghost commented 11 months ago
👇 Click on the image for a new way to code review #### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/FreezingMoon/AncientBeast/2510/662a430f/4d720bbc7b668529e771eb2df1546e95c4f4ab13.svg)](https://app.codesee.io/r/reviews?pr=2510&src=https%3A%2F%2Fgithub.com%2FFreezingMoon%2FAncientBeast) #### Legend CodeSee Map legend
DreadKnight commented 11 months ago

@xTammaro Heya! Did a bit of testing and found some issues:

xTammaro commented 11 months ago

I have fixed both issues! Only one cancel cursor is shown, and only for hexes after the first creature in the path:

Screenshot 2023-10-17 at 12 40 30 pm

Also hovering over this first empty hex will only highlight the first creature, and clicking on it will attack the first creature:

Screenshot 2023-10-17 at 12 38 22 pm

Let me know if anything else needs tweaking, otherwise I think this should work as expected!

xTammaro commented 11 months ago

Sorry I have found an issue, this is not ready.

xTammaro commented 11 months ago

The issue is fixed, now works with multi-directional targets:

Screenshot 2023-10-17 at 3 46 59 pm
DreadKnight commented 11 months ago

@xTammaro Looks good to me. Well done! 👍🏻