project logo visible after browser hotkeys press [bounty: 4 XTR]

[DreadKnight]

Pressing some browser hotkeys that include shift key and which steal focus, such as Ctrl+Shift+M, will have the project logo remain visible over the combat location's background. There was an attempt at fixing this for another scenario found #2514

A decent way of fixing this: if Shift is involved in any hotkey combo, just hide the logo.

[Rondev9]

Hey @DreadKnight are you saying that we need to resolve conflicts with browser hotkey functionality, especially those that involve key combinations like Ctrl+Shift+M that steal focus and impact the visibility of our project's logo over the combat location's background?

[DreadKnight]

@Rondev9 Not really. There's a feature showcasing project logo that while rather trivial, it's kinda buggy as well and gets revealed way more or remains that way at times, so we're fixing all that.

On Mon, Nov 6, 2023, 6:12 PM Ganesh Mukhi @.***> wrote:

Hey @DreadKnight https://github.com/DreadKnight are you saying that we need to resolve conflicts with browser hotkey functionality, especially those that involve key combinations like Ctrl+Shift+M that steal focus and impact the visibility of our project's logo over the combat location's background?

— Reply to this email directly, view it on GitHub https://github.com/FreezingMoon/AncientBeast/issues/2521#issuecomment-1795315179, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEPNXYH3AHVJJLCOQQQ7A3YDEEABAVCNFSM6AAAAAA6UFJXUGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJVGMYTKMJXHE . You are receiving this because you were mentioned.Message ID: @.***>

[Rondev9]

@DreadKnight Actually I had worked on it locally, and now it's working fine, where the hot key Ctrl+Shift+M won't mess with the browser anymore.

[DreadKnight]

Well, the issue is not really about messing with game or browser hotkeys, but about the issue... anyway feel free to make PR whenever, but I'll be checking starting weekend.

On Mon, Nov 6, 2023, 6:25 PM Ganesh Mukhi @.***> wrote:

@DreadKnight https://github.com/DreadKnight Actually I had worked on it locally, and now it's working fine, where the hot key Ctrl+Shift+M won't mess with the browser anymore.

— Reply to this email directly, view it on GitHub https://github.com/FreezingMoon/AncientBeast/issues/2521#issuecomment-1795346290, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEPNX33ST7BXTYH2S2OS6LYDEFQFAVCNFSM6AAAAAA6UFJXUGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJVGM2DMMRZGA . You are receiving this because you were mentioned.Message ID: @.***>

[Rondev9]

Great :) could you please assign this issue to me ?

[DreadKnight]

@Rondev9 Done ✔️

[Rondev9]

Thank you @DreadKnight, I'll be on it 👍

[Rondev9]

Hey @DreadKnight, I think I've resolved the issue, and I hope it helps improve the project. I've also raised a PR 📦. Please feel free to ping me if you need any changes 😊.

[Rondev9]

Hi @DreadKnight ,

I hope you're doing well! 🌟 Just a friendly reminder regarding the PR I submitted. I'd appreciate it if you could take a moment to review it. Your insights are invaluable, and I want to make sure the changes align with your expectations.

Thank you for your time!